Add settings to change email subjects

incuna / django-user-management

User management model mixins and api views.

BSD 2-Clause "Simplified" License

57 stars 24 forks source link

Add settings to change email subjects #156

Closed adam-thomas closed 8 years ago

adam-thomas commented 8 years ago

@incuna/backend review please?

adam-thomas commented 8 years ago

OK. So I have this test failure and I have no idea what the problem is.

There's one test (that I haven't touched) which is now not sending an email. The test I added is an exact duplicate of the other test, up to the point where the email is/isn't sent, aside from override_settings. I've tried removing override_settings, adding it to the original test, undoing the change in the notification function, and so on. There are no tests in the same file with the same name as the original. I HAVE NO IDEA WHAT'S GOING ON. Please help. D:

adam-thomas commented 8 years ago

Bump? I need advice on this failure.

adam-thomas commented 8 years ago

halp?

adam-thomas commented 8 years ago

OK. If I delete the new test, the original test passes again.

LilyFoote commented 8 years ago

What happens if you run the tests in reverse order?

adam-thomas commented 8 years ago

I don't know if the --reverse is ignored by run.py, but the same failure occurs (???).

adam-thomas commented 8 years ago

I've also tried explicitly setting email=something@unique.com in each of the UserFactory.create() declarations to dodge clashing, and that didn't work either.

adam-thomas commented 8 years ago

This should fix it, thank you @Ian-Foote!

adam-thomas commented 8 years ago

hooray, Travis is going green now :D

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 2a96672b6d54bf3d7d5f43c1a73ed007160e7ac1 on make-email-subjects-into-settings into 61bb2d02235323ea7dd37f1301a6fef72c203257 on master.

adam-thomas commented 8 years ago

Updated

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling fbcd2a28bb732fa23f6abaa648b88b20a9c68aa7 on make-email-subjects-into-settings into 61bb2d02235323ea7dd37f1301a6fef72c203257 on master.