search

incuna / incuna-sass

Incuna's Sass Library
MIT License
2 stars 2 forks source link

Added mixin to output all text inputs. Reset iOS styling put on to text inputs. #14

Closed perry closed 10 years ago

perry commented 10 years ago

@incuna/frontend please.

grahamgilchrist commented 10 years ago

So the idea is we use this to reset the iOS defaults and then style ourselves?

It's sort of an optional reset?

perry commented 10 years ago

iOS adds a border radius and inner box shadow by default to all text inputs. Generally we'll not want this at all, so I think it should be on by default.

grahamgilchrist commented 10 years ago

@perry Yes, I suppose the question is if we are not providing custom form styles, should they see the standard iOS boxes?

It goes with the question of whether we should style form elements at all, or leave them up to the OS. Since we're already applying other form styles already in incuna-sass, I think it makes sense to do this as well by default for consistency? Maybe including the forms.sass should use the text-inputs mixin by default?

grahamgilchrist commented 10 years ago

or should it be in reset.sass? Go with the other resets, or with the base form styles?

henrahmagix commented 10 years ago

If we're providing a reset for text inputs, I think it should be across the board. If other browser's aren't styling it already, then there's no difference, even when we want to add styles. Plus if/when they do, we won't be caught out.

perry commented 10 years ago

It's not really a reset, it's more of a normalisation.