search

incuna / incuna-sass

Incuna's Sass Library
MIT License
2 stars 2 forks source link

Comment on the end of selector causes warning #20

Closed pandalion closed 10 years ago

pandalion commented 10 years ago

WARNING on line 152 of .../incuna-sass/incuna-sass/_normalize.sass: This selector doesn't have any properties and will not be rendered.

Sass no likey comment on end of selector. Doesn't seem to mind on the end of a property. But we don't really do comments on end of lines anymore, this one seems a bit overkill anyway.

pandalion commented 10 years ago

@incuna/frontend please see this, if it can be merged I can release a new version?

perry commented 10 years ago

Can you put the comments above the line instead?

grahamgilchrist commented 10 years ago

@pandalion apart from one comment, looks good.

henrahmagix commented 10 years ago

I think perhaps revert this and instead just remove // 1 and change the comment above to point to the reference. Everything else can stay as it was.

Trying to get // 1 into the selector at that point is going to cause the same issue rather than solve it.

perry commented 10 years ago

Thanks @pandalion

henrahmagix commented 10 years ago

:+1: