make sure all the mixins are imported in mixins.sass

[hippogriffic]

I'm not sure why the sprites one wasn't there before.

I realised that I missed this when I add the svg mixins before.

If the sprites one wasn't in there for a reason please tell me and I'll take it out again.

Also not sure if this requires an update to the changelog?

@incuna/frontend

[henrahmagix]

If the sprites one wasn't in there for a reason please tell me and I'll take it out again.

So a project doesn't have to have a sprites folder setup just to compile the Sass. Perhaps Compass has changed in the meantime, but it would either error or warn or just get upset if there weren't any folders and/or images to work on.

Our seed projects that use this have it commented out, so including it in a project is trivial.

Perhaps now is the time to add a comment explaining the above? Yay docs!

[henrahmagix]

Also not sure if this requires an update to the changelog?

All updates should go in the changelog, unless they're trivial repo settings (edit: now I'm not sure what I mean by that). Maybe readme changes shouldn't, but I think it's safer/easier to put all updates in the changelog.

[hippogriffic]

@henrahmagix so leave it in and comment or take it out and comment?

[henrahmagix]

"leave it in and comment" I think would be best :+1:

[hippogriffic]

@henrahmagix how's the comment, if you want more description let me know (also let me know the description because this is the extent of my understanding)

[henrahmagix]

@hippogriffic Have you tested with it imported in a project that has no sprites folders or images? What is output?

[hippogriffic]

@henrahmagix better? Also I did not test I don't know how, but is that necessary now?

[henrahmagix]

but is that necessary now?

Yes, definitely necessary =)

I did not test I don't know how

• cd thisfolder
• bower link
• make a new folder somewhere else and cd to it
• bower link incuna-sass -> it goes in bower_components/incuna-sass
• touch test.sass or make that file with your own method
• import everything in that file like @import incuna-sass/thing
• run compass compile --force --sass-dir . --import-path bower_components/incuna-sass
• see if it errors

[henrahmagix]

A more detailed test.sass will call all the functions, @include all the mixins, and @extend all the extensions. @hippogriffic Please paste the contents of your test.sass into #44: we could use it for the test suite.

[henrahmagix]

Alternatively, you could bower link incuna-sass in a current project and see if that project errors.

[hippogriffic]

@henrahmagix tests are passing for these changes - see #44 for more details @incuna/frontend please review