search

incuna / incuna-sass

Incuna's Sass Library
MIT License
2 stars 2 forks source link

split out mixins and helpers #5

Closed pandalion closed 10 years ago

pandalion commented 10 years ago

@perry in a project's main.sass this would change the importing to

@import incuna-sass/functions
@import incuna-sass/helpers
@import incuna-sass/mixins
@import incuna-sass/mixins/sprites

(sprites could just go in mixins, dont know if there was a reason for you keeping it separate)

I removed the import of functions to mixins because functions is imported in main.sass so I couldn't see why it needed to be imported to mixins also? unless it was being used in the mixins but it didn't seem to be?

perry commented 10 years ago

Keep sprites separate as the sass will not compile if the images directories do not exist.

Should mixins be imported above helpers?

pandalion commented 10 years ago

@perry hm is there any difference? don't mind really.

perry commented 10 years ago

Helpers could depend on mixins. Mixins wouldn't depend on a helper.

pandalion commented 10 years ago

okay so

@import incuna-sass/functions
@import incuna-sass/mixins
@import incuna-sass/mixins/sprites
@import incuna-sass/helpers

If this gets merged I guess that needs to be updated somewhere? not in that project?

perry commented 10 years ago

Perhaps a section in the README with sensible default imports?