search

incuna / incuna-sass

Incuna's Sass Library
MIT License
2 stars 2 forks source link

remove compass dependent sass #51

Closed hippogriffic closed 9 years ago

hippogriffic commented 9 years ago

remove things that can't be used at all without compass - sprites, browsers, inline-block. Rework box-sizing helpers to not use compass. Some of the components files still use compass mixins and will have to be updated with replacements

This is a big scary one, I do not expect that it will be merged easily.

I tried to remove as much as possible in one go. If you think I've removed something unnecessarily please tell me.

I am opening an issue to discuss our options for replacing the compass mixins being used in the components files

@incuna/frontend

hippogriffic commented 9 years ago

@incuna/frontend please review

henrahmagix commented 9 years ago

:+1:

perry commented 9 years ago

There are a few comments on incuna-sass/_normalize.sass - perhaps we could consider using the bower package for it instead?

hippogriffic commented 9 years ago

@perry we're just discussing this, I think we're going to give this one a try: https://github.com/necolas/normalize.css/blob/master/normalize.css

perry commented 9 years ago

Sounds like a plan. Perhaps add it to the bower.json of this project as a dependency? You may have to add the directory as an import path in sass/compass/whatever.

pandalion commented 9 years ago

@hippogriffic @perry hi perry! :D yeah, perhaps if we dont need to change that we can just do it as perry suggest. But perry.. no compass anymore! ;)

It currently only seems to be in css though, so how can we import it as sass or scss?

hippogriffic commented 9 years ago

@perry ok, so I have normalise.sass now, what am I doing with bower.json?

hippogriffic commented 9 years ago

@incuna/frontend please review

pandalion commented 9 years ago

Looks good to me, let's do it !