incuna / incuna-sass

Incuna's Sass Library
MIT License
2 stars 2 forks source link

create incuna normalise file #77

Closed hippogriffic closed 8 years ago

hippogriffic commented 8 years ago

for sass we use on all our projects, after a slack discussion with the sass ladies

let me know if you think there's something else that could go in here.

I went with 1.4 for line height because I feel like I've used that most often in projects, but will happily change it if people disagree.

@incuna/frontend please review

maciejpi commented 8 years ago

I'm good with that

pandalion commented 8 years ago

Looks good! (I know you're moving from mixins now to the root)

hippogriffic commented 8 years ago

@pandalion fixed

henrahmagix commented 8 years ago

I went with 1.4 for line height because I feel like I've used that most often in projects, but will happily change it if people disagree.

👍 for me

grahamgilchrist commented 8 years ago

Looks good 👍

Since there is another _normalise.sass, maybe a description somewhere (comments in the files or in the readme) about the difference and when you would want to use either?

hippogriffic commented 8 years ago

@incuna/frontend can this be merged?

hippogriffic commented 8 years ago

@henrahmagix @perry done :)

perry commented 8 years ago

Can I press the green button :D?

hippogriffic commented 8 years ago

of course you can, in fact please do :D

perry commented 8 years ago

hippogriffic commented 8 years ago

thanks :)