search

indeedeng / django-ptrack

Tracking pixel library for Django
Apache License 2.0
40 stars 17 forks source link

Changes for Python 3. #2

Closed ramashishb closed 6 years ago

ramashishb commented 6 years ago

Changes for working with Python 3. Strings are converted to bytes by utf-8 encoding.

latimer1 commented 6 years ago

Hi Ramish! Thanks for the merge request for updating this library to python 3. The change looks pretty straightforward. I'll review in the next few days and release a new version!

ramashishb commented 6 years ago

Hi,

One more change is required for the library to work. json.loads expects a str not bytes. I have done the changes and raised a new pull request. Please review and merge. Let me know once you have increased the version. I will update my requirements.txt.

Thanks, Ramashish

On Tue, Mar 6, 2018 at 1:49 AM, latimer1 notifications@github.com wrote:

Hi Ramish! Thanks for the merge request for updating this library to python 3. The change looks pretty straightforward. I'll review in the next few days and release a new version!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/indeedeng/django-ptrack/pull/2#issuecomment-370550886, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFT-BEZ2pdAZPfDWP7cYTOPp5ZoFkx0ks5tbZ21gaJpZM4Sbbiq .