search

indeedeng / fibtest

Apache License 2.0
55 stars 16 forks source link

Make more portable, enhance README #4

Open Nuru opened 4 years ago

Nuru commented 4 years ago

What

  1. Make this test more portable by
    1. allowing for different directory setups for cpu and cpuacct
    2. allowing for possibly missing scaling_governor and/or energy_performance_preference
    3. fail if unable to create cgroup
  2. Enhance README to explain what but is being tested and how, and explain limitations of the test.
Nuru commented 4 years ago

@chiluk wrote

This patch breaks throttled metrics on Cent 7. That's why I haven't approved it yet. Throttled periods should be 50+ for both good and bad kernels but it ends up being 0.

I would be happy to fix this if I knew how. I don't have Cent 7 on hand and am not familiar with Centos at all. Are you sure it is the patch that broke Cent 7 and not the original test? My guess would be that Cent 7 has disabled CFS in a way that this test does not take into account.

If you know how to fix this, feel free to make the change. If not, I will look into it when I have time.

chiluk commented 4 years ago

Yeah time is not something I have right now with daycares being closed. Additionally this project was never intended to grow into a living project. I'll try to look at it if I ever find that elusive time.