search

indeedeng / iwf

iWF is a WorkflowAsCode microservice orchestration platform offering an orchestration coding framework and service for building resilient, fault-tolerant, scalable long-running processes
MIT License
537 stars 55 forks source link

Replace firingUnixTimestampSeconds with duration field #372

Closed longquanzheng closed 5 months ago

longquanzheng commented 8 months ago
  1. more accurate to use relative time
  2. easier for unit test
  3. cleaner and easier to read the history events
longquanzheng commented 6 months ago

https://github.com/indeedeng/iwf/pull/388 NOTE： This will need more work than this PR due to continueAsNew -- the duration value cannot be used in next run, because after continueAsNew, the workflow.now() has changed. We have to also write down the start time, or convert it to firingUnixTimestamp when the timer started, in order to pass to next run

longquanzheng commented 5 months ago

https://github.com/indeedeng/iwf/pull/393