search

indeedeng / proctor

Proctor is a Java-based A/B testing framework developed by, and used heavily within, Indeed.
http://opensource.indeedeng.io/proctor
Other
465 stars 123 forks source link

Add enableExposureLogging flag in ConsumableTestDefinition #152

Closed bayareabear closed 8 months ago

bayareabear commented 9 months ago

Add lastRevisionDate in TestDefinition so that we can log the test according to their update activity time

zacharygoodwin commented 9 months ago

Need to add field to the ConsumableTestDefinition.

May only need to update the ConsumableTestDefinition and can leave the test definition class alone since the field will be populated by proctor builder rather than stored in the test definition entry in the DB. When the builder runs it calls: https://github.com/indeedeng/proctor/blob/master/proctor-common/src/main/java/com/indeed/proctor/common/ProctorUtils.java#L158 which calls the fromTestDefintion to convert to the object proctor consumers use.

bayareabear commented 8 months ago

This is no longer needed for now