search

indeedeng / proctor

Proctor is a Java-based A/B testing framework developed by, and used heavily within, Indeed.
http://opensource.indeedeng.io/proctor
Other
465 stars 123 forks source link

PROC-1471: Encode cookie for Rfc6265CookieProcessor #161

Closed zacharygoodwin closed 7 months ago

zacharygoodwin commented 7 months ago

Will this have any unintended consequences? For example, if some team is parsing the cookie and expecting a comma?

That is a good question, I think it would. However, I think it is better practice and a improvement that they likely should handle as well. Thoughts? @stevenchen-indeed

vanhaxl commented 7 months ago

Will this have any unintended consequences? For example, if some team is parsing the cookie and expecting a comma?

That is a good question, I think it would. However, I think it is better practice and a improvement that they likely should handle as well. Thoughts? @stevenchen-indeed

I think we should consider this. It seems there are cases where this cookie value prForceGroups is being used source graph