search

indeedeng / proctor

Proctor is a Java-based A/B testing framework developed by, and used heavily within, Indeed.
http://opensource.indeedeng.io/proctor
Other
464 stars 123 forks source link

LICENSE file does not list copyright holder or copyright year #90

Closed juliaschiller150 closed 1 year ago

juliaschiller150 commented 1 year ago

I noticed the LICENSE file has boilerplate not filled in:

Copyright [yyyy] [name of copyright owner]

This should say Copyright 20xx Indeed, correct?

aboivineau commented 1 year ago

Thanks for flagging this. @kevindigo , please could you confirm from OSS side ?

kevindigo commented 1 year ago

Thanks @aboivineau. Someone from Indeed's open source team should post guidance here shortly.

coffeesippa commented 1 year ago

@tcschiller thanks for reporting this issue. We looked into the licensing guidelines and confirmed that without the copyright line of text, the license is still valid and our rights are still protected (ie, exclusion is low risk). Many projects do not include this text. However, I think it's still worth making these changes to align with the specified terms.

@aboivineau or @tcschiller do you want to submit an MR? We'll need to:

  1. Add the following line at the top: 
    
Copyright 2014-2023 Indeed

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.



2. Remove all text after **END OF TERMS AND CONDITIONS** ( ie, the appendix)

@aboivineau  or @tcschiller would you like to submit a MR for these changes?
juliaschiller150 commented 1 year ago

I'm happy to do so. Will get it opened today. Thanks!