Some adblockers prevent the Character Social tab from working correctly

indentlabs / notebook

Notebook.ai is a set of tools for writers, game designers, and roleplayers to create magnificent universes – and everything within them.

http://www.notebook.ai

MIT License

364 stars 75 forks source link

Some adblockers prevent the Character Social tab from working correctly #348

Open drusepth opened 5 years ago

drusepth commented 5 years ago

Expected behavior

Clicking the Social tab on character pages should show the fields in the Social tab, like any other tab

Actual behavior

If a user is using an AdBlocker, clicking the Social tab hides all tabs and then shows nothing. Disabling the AdBlocker makes clicking the Social tab work as expected.

What to do

We should figure out what the heck is causing this (is it literally just the word "Social" in a link?) and figure out a solution that isn't just telling users to turn off their ad blocker and/or rename the Social tab to something else.

SethFalco commented 4 years ago

It might be worth revisiting this as I'm using uBlock Origin on Firefox, but the Social tab looks fine to me regardless of if it's enabled or not. :thinking:

I've tried both in the editor view, and the unauthenticated public view.

If it's a still an issue, it might be nice to know which ad blocker this occurred with?

Edit: I'm an idiot, didn't realize there was a name of an ad blocker in the issue title.

SethFalco commented 4 years ago

I've just tested using Adblock Plus on Chromium, but same results as above.

Both in the editor view, and unauthenticated public view, the Social tab appears to look perfectly fine for me anyway.

drusepth commented 4 years ago

Hmm, thanks for looking into this. I also tested with Adblock Plus and wasn't able to replicate it, but I still get several emails per month of people experiencing this, so I think there's gotta be something else triggering it. I don't typically use adblockers so I'm not very familiar with how they work, but it could also be some combination of plugins (if they support them).

The people that have responded to my query of what adblocker they were using have all said Adblock Plus. I'll go ahead and rename this issue, but I think it should stay open until we've got more information on what's actually causing it and get it fixed.