No icon for nighttime partly cloudy

inderdhir / DatWeatherDoe

Simple menu bar weather app for macOS

Apache License 2.0

526 stars 34 forks source link

No icon for nighttime partly cloudy #44

Closed grr closed 3 years ago

grr commented 3 years ago

It's odd to see this icon Partly cloudy in the middle of the night.

inderdhir commented 3 years ago

Fixed in 2.1.3!

grr commented 3 years ago

I'm using 2.1.3 and I haven't yet seen any of the night time icons being used in the menubar. It's 3AM here and I'm seeing this:

grr commented 3 years ago

been having bad weather here, so took a while to actually see some night icons, but i'm still seeing the daylight icons beuing used hours before sunrise. i don't have enough data points yet, but it looks like either the data or the calculation to determine sunrise might be the cause.

grr commented 3 years ago

it's 1am and still seeing daylight icons, so it's probably not related to the sunrise calculation or data.

inderdhir commented 3 years ago

I have a fix up (#48), will test for a couple of days and cut a release if all goes well. Thanks for the help!

grr commented 3 years ago

cool, was about to also report that i just saw night time icons during the day, but it looks like this change might fix that.

inderdhir commented 3 years ago

2.1.4 was just released, let me know if that fixes your issue!

grr commented 3 years ago

works for me. thanks!