when encoding key that is null, return null

indexeddbshim / IndexedDBShim

A polyfill for IndexedDB using WebSql

Other

968 stars 191 forks source link

when encoding key that is null, return null #231

Closed zawaideh closed 8 years ago

zawaideh commented 9 years ago

ran into this problem when having a key that can be null.

brodycj commented 9 years ago

Suggestion on my part to add a test case, if possible.

zawaideh commented 8 years ago

Is there a unit test file for Key? Not that familiar with the codebase, if I point me to where you are thinking the test case should go, I'd be happy to add it.

brettz9 commented 8 years ago

I've adapted this PR and incorporated it into master. Feel free to comment further, add a new bug, etc. if you find any new issues. With the W3C tests just added, we can hopefully improve quality even further. See also #238

brettz9 commented 8 years ago

Sorry, I was premature in adding my code. Please pull again from master if you've already updated, as I've fixed things to either throw a proper error or silently ignore, as per spec behavior. Please see my comment at https://github.com/axemclion/IndexedDBShim/issues/215#issuecomment-227218203 .