search

indexeddbshim / IndexedDBShim

A polyfill for IndexedDB using WebSql
Other
968 stars 191 forks source link

Fix object type #238

Closed wibimaster closed 8 years ago

wibimaster commented 8 years ago

The object "types" does not know the "object" type ; test on a iPhone 4S with iOS 8.3, got a big fail with undefined object.

This fix was test on the same iPhone :)

Thanks !

wibimaster commented 8 years ago

Ping, is the author always active ?

axemclion commented 8 years ago

@wibimaster Not sure what you meant by "author always active"

wibimaster commented 8 years ago

@axemclion Thanks for your answer, just to know if I have a chance to see my request read or if I have to fork the project ;)

axemclion commented 8 years ago

@wibimaster I did see your pull request, but it is going to be hard for me to find time to review it. I am hoping that a few others who are using the project review the request, and if they are good, I can merge it in.

wibimaster commented 8 years ago

@axemclion Okay, I understand :) It's just an "obstacle course" for us because after updated your repo, we have to ask for an update on https://github.com/ABB-Austin/cordova-plugin-indexeddb-async ;)

@davaxi Thanks, I fix that ASAP, just an oversight :)

wibimaster commented 8 years ago

Done, should close #231 too ;)

brettz9 commented 8 years ago

As mentioned in #231, I've adapted this PR and incorporated it into master. Please note that if you are using your PR alone, there are some unintended consequences in its mistakenly allowing objects or null as keys (as values they are ok), but I've fixed these in master. Feel free to comment further, add a new bug, etc. if you find any new issues. With the W3C tests just added, we can hopefully improve quality even further.

brettz9 commented 8 years ago

Sorry, I was premature in adding my code. Please pull again from master if you've already updated, as I've fixed things to either throw a proper error or silently ignore, as per spec behavior. Please see my comment at https://github.com/axemclion/IndexedDBShim/issues/215#issuecomment-227218203 .