search

indexeddbshim / IndexedDBShim

A polyfill for IndexedDB using WebSql
Other
968 stars 191 forks source link

Add shimIndexedDB.__unuseShim() #272

Closed bolasblack closed 8 years ago

bolasblack commented 8 years ago

I need migrate data from IndexedDBShim to indexedDB.

So I hope I can call __useShim() export all data from IndexedDBShim, then call __unuseShim() and import them to the real indexedDB.

axemclion commented 8 years ago

Should this be a part of the library ? IMHO, this could be a script that you run before importing the shim. Then you could reassign the constants.

I think it would make sense to publish this as a separate library instead of making the function available as a part of the shim. We could also link to the "unshimming" library from the README.

bolasblack commented 8 years ago

Hmmmmm... I think you are right! Thank you! :P

axemclion commented 8 years ago

@bolasblack Thanks for the PR though, I did not mean to prevent it from being merged. I just thought that it would make sense as a separate library. If you believe that it should be a part of this, you should re-open and we could let other contributors chime in.

bolasblack commented 8 years ago

@axemclion I agree with you, about unshimming, it's not a necessary function and users can implement it out of IndexedDBShim, so I think it's no need to be a part of the library.