Fix: Make references to websql using module id instead of by path

indexeddbshim / IndexedDBShim

A polyfill for IndexedDB using WebSql

Other

968 stars 191 forks source link

Fix: Make references to websql using module id instead of by path #282

Closed erikvold closed 7 years ago

brettz9 commented 7 years ago

Aha... Good find, thanks! Aim to get to this shortly...

erikvold commented 7 years ago

Hmm actually I think I was mistaken, this patch doesn't seem to resolve the error I was getting in https://github.com/axemclion/IndexedDBShim/issues/259#issuecomment-279206410

brettz9 commented 7 years ago

I did incorporate your change, but I think I might have added the relative path myself due to this approach not working either. :) I would think your approach would work as it is a dependency of thisone...Anyways closing this but if you find another fix, feel free to make a new PR or overwrite this one.

brettz9 commented 7 years ago

Should truly be fixed now in master (as discussed in #262).