search

indexeddbshim / IndexedDBShim

A polyfill for IndexedDB using WebSql
Other
968 stars 191 forks source link

Fix #259 - Revert part of 66224374ec34a89d13a8daf207f485a986177117 #292

Closed erikvold closed 7 years ago

erikvold commented 7 years ago

It seems that this code was providing a path that does not exist. I'm not quite sure why it was added in https://github.com/axemclion/IndexedDBShim/commit/66224374ec34a89d13a8daf207f485a986177117 @brettz9 ?

erikvold commented 7 years ago

Note: Please see #291

brettz9 commented 7 years ago

I see, good catch and sorry for the headache--I bet this was a result of my trying to get things work when I was using a relative path. I'll merge locally and rerun all the tests (including in the browser) to be sure.

brettz9 commented 7 years ago

Actually, I see why I did it now... Notice that your path is now hard-baked into the package as mine had been a while back when the first report came in. I think browserify does it this way for the globals so I tried at least making it relative, but from everybody's reports, apparently that doesn't work in all environments (apparently when requiring outside of the IndexedDBShim package).

I think the solution is going to simply be to have the browserify process exclude websql/sqlite3. (If that doesn't work (though I think it should), we'd need to have the build run at install time in the case of Node, though that would require a lot of dependencies.)