search

indexexchange / yieldbot-adapter

0 stars 0 forks source link

Return parcel ad markup for SafeFrame rendering support #1

Open elljoh opened 6 years ago

elljoh commented 6 years ago

What is the best way to make an update to the Yieldbot adapter return parcel ad markup for your IndexExchange current publisher integrations with Yieldbot? i.e. I am assuming the master-v2 branch is what is used in your production integrations.

While Yieldbot intends to complete the IndexExchange HeaderTag adapter certification and take an active role in adapter contribution and maintenance; I am interested if there is a process to expedite an update to the ad markup tag embedded in the Yieldbot adapter.

The update to the Yieldbot ad markup will enable cross-origin aka SafeFrame support for creative rendering.

Cheers

ix-certification commented 6 years ago

Hi @elljoh

We've added your account as a collaborator on this repo. Feel free to create a new branch from master-v2 and commit your changes on it. After that once a PR request has been created, we'll review the changes and provide feedback if any. Additionally, at this stage we'll also provide a fully functional test wrapper which you'll be able to use to validate your change and sign off on before we merge the changes in production.

ix-certification commented 6 years ago

@elljoh

And with respect to completing the HeaderTag adapter certification process, we would really appreciate it if you can reach out to the following individuals to continue having that conversation:

elljoh commented 6 years ago

Hi @jas-singh,

regarding the comment above, would you be able to (or assign someone to) review #2 ?

Thanks.

Cheers, John

jas-singh commented 6 years ago

Hi @elljoh,

The #2 has been assigned to the ix-certification team for review. I would suggest emailing the above mentioned individuals so that they can work with your team on how these changes will be reviewed, merged & deployed.