search

indexiatech / ember-forms

Smart, Intuitive forms for Ember.js styled with Bootstrap, Multi layouts and Validation support.
http://indexiatech.github.io/ember-forms
Apache License 2.0
218 stars 45 forks source link

help-block added even if no helpText #25

Open simonihmig opened 10 years ago

simonihmig commented 10 years ago

A span with class "help-block" is rendered even if there is no helpText (error messages) available.

This is not visible in a vertical form, but in a horizontal one this increases the distance to the following form. See the following screenshot taken from http://ember-addons.github.io/ember-forms/#/overview: image

This can easily be reproduced: fill in something valid in the full name field, focus out of the field: the field turns green (has-success class), which is ok, but the distance to the password field is increased by the (empty) help-block!

It should not render a help-block, if it is empty anyway!

BenjaminWinter commented 9 years ago

@asaf just wanted to bump this / confirm that this actually is a general bug, as this issue is open for a long time already and renders the horizontal layout suboptimal at best.

asaf commented 9 years ago

@BenjaminWinter Hey, I didn't give it so much attention because it seems like something that has not much effect on anything,

I'll assign it to next ver.

clessg commented 9 years ago

Current workaround for me is

form .help-block:empty {
  display: none;
}