Form fields and integration tests

indexiatech / ember-forms

Smart, Intuitive forms for Ember.js styled with Bootstrap, Multi layouts and Validation support.

http://indexiatech.github.io/ember-forms

Apache License 2.0

218 stars 45 forks source link

Form fields and integration tests #32

Closed gangster closed 10 years ago

gangster commented 10 years ago

Hi there. I've been using ember-forms in my project and it's been working out great so far. Thanks to all the contributors to the project.

Is it possible to add custom classes to the input fields or the wrappers? The use case I have in mind is writing integration tests. Not seeing how to get a handle on the form field without being able to reference it by a known selector.

Thanks again!

toranb commented 10 years ago

+1 here

I'm doing some integration testing myself and realized I can't set the id of the input (to select during my integration test for example)

any idea how this could be added/ or do you have plans to support this? any reason this isn't already in the library? Thanks for such a great project! keep up the great work!

williamsbdev commented 10 years ago

I am also having this problem. I attempted to put an id="id_name" on the em-input and it actually puts the id name on the div surrounding the input. How would I be able to put an id on the input instead of the div?

Thanks!

asaf commented 10 years ago

So to summarize:

Add a way to add custom classes to input fields and wrappers
Propagate some property from the top level component as the id of the sub components.

toranb commented 10 years ago

Sounds good - the big one is allowing me to set an id for the element (so I can find it/ inspect it with ember-testing). The first bullet point (to add classes) would be a nice + 1 / iteration on this story

asaf commented 10 years ago

It's possible to set cid="someId" and it'll be propagated to the input control itself.

Regarding custom classes, I opened an issue for it #36