search

indexiatech / ember-forms

Smart, Intuitive forms for Ember.js styled with Bootstrap, Multi layouts and Validation support.
http://indexiatech.github.io/ember-forms
Apache License 2.0
218 stars 45 forks source link

Two dependencies missing? #68

Closed consideRatio closed 9 years ago

consideRatio commented 9 years ago

The ember-idx-forms modules package.json contains devDependencies of "broccoli-merge-trees": "^0.2.1", "broccoli-static-compiler": "^0.2.1",

But when i run the test-server command using ember-cli (ember s) inside MYPROJECT dir, i get the following error.

Error: Cannot find module 'broccoli-merge-trees' at Object. (.../MYPROJECT/node_modules/ember-idx-forms/index.js:3:18)

It seems that ember-idx-forms needs broccoli-merge-trees as a dependency right? This is contained on line 3 and 4 in the index.js file:

var mergeTrees = require( 'broccoli-merge-trees' ), pickFiles = require( 'broccoli-static-compiler' );

So, it should list those inside dependencies instead of devDependencies right? I made a pull request as an attempt solve this here, I do not have a deep understanding of what this will result in since I'm a bit dazzled by everything works. https://github.com/indexiatech/ember-forms/pull/69

My quickfix for myself have been to add "broccoli-merge-trees": "^0.2.1", "broccoli-static-compiler": "^0.2.1", to MYPROJECT/package.json's devDependecies.

asaf commented 9 years ago

This is all because of fontawesome, which is not really a mandatory but recommended only, I will remove the dependencies of these two addons.

asaf commented 9 years ago

Also released a minor version (0.5.1) for this change,

Please try again, I hope it's fine now.