search

indexiatech / ember-forms

Smart, Intuitive forms for Ember.js styled with Bootstrap, Multi layouts and Validation support.
http://indexiatech.github.io/ember-forms
Apache License 2.0
218 stars 45 forks source link

Changes in model now reflect on form: Issue #82 & Issue #23 #92

Closed xcskier56 closed 9 years ago

xcskier56 commented 9 years ago

Changes by @BenjaminHorn and @michetti to allow updates in the model to be reflected in the form. This should close Issue #82 and Issue #23

joshpfosi commented 9 years ago

@asaf, will this be merged soon? I am debating forking from this branch as this change is make or break.

koryteg commented 9 years ago

+1 for this. will this be merged soon?

xcskier56 commented 9 years ago

@joshpfosi Have you created a fork for this feature? I'd be happy to help.

joshpfosi commented 9 years ago

I actually have not. I don't have time at the moment, but it should be straightforward to take this pull request, right?

koryteg commented 9 years ago

@joshpfosi for myself I just set my package.json to get this fork and commit for the time being, until this gets updated. I should probably fork @xcskier56 so I am not depending on his fork.

joshpfosi commented 9 years ago

Any progress on this? Cans someone list their package.json? How can I pull in http://github.com/perk-health/ember-forms.git into my project? Thanks!

asaf commented 9 years ago

Merged.

joshpfosi commented 9 years ago

I still experience this problem even with EmberForms 0.6.0. Looking into this now, but it appears to be the identical problem.

pedrokiefer commented 9 years ago

@joshpfosi I'm not sure if this is not already fixed on this fork: https://github.com/piceaTech/ember-rapid-forms

joshpfosi commented 9 years ago

@pedrokiefer, I experience an issue when using ember-rapid-forms:

version: 0.1.15
Cannot find module 'handlebars'
Error: Cannot find module 'handlebars'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at /Users/joshpfosi/shearwater/ember/bower_components/ember/ember-template-compiler.js:34:16
    at Object.<anonymous> (/Users/joshpfosi/shearwater/ember/bower_components/ember/ember-template-compiler.js:332:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)

Any ideas on this?

pedrokiefer commented 9 years ago

@joshpfosi never saw this error before.

joshpfosi commented 9 years ago

Hmm. Just created a fresh ember app and experienced the same issue: https://github.com/joshpfosi/ember-rapid-forms-bug

Do you have a working package.json I could check against?

Edit: Confirmed, without ember-rapid-forms the server ran w/o errors

pedrokiefer commented 9 years ago

@joshpfosi I think it's something with the version of your ember-cli, but I might be mistaken.

Confirmed, you are running ember 1.8, try updating to ember-cli 0.2.3 and ember 1.10 or 1.11.