search

indexiatech / ember-idx-modal

Ember Indexia Modal
http://indexiatech.github.io/ember-idx-modal/#/gettingstarted
Apache License 2.0
17 stars 13 forks source link

Fixes config singleton usage #9

Closed pzuraq closed 9 years ago

pzuraq commented 9 years ago

When multiple Indexiatech addons are included in a single app, they check if Em.Config exists in the initializers and if not create it. However, if Em.Config does exist they continue to use the imported Config variable. This variable is the constructor for the config object, not the instance of it created and added to Ember. Errors are thrown by the 2nd, 3rd... etc plugin trying to initialize their configurations.

The solution is to use initialize if it doesn't exist Em.Config and use it exclusively for setting configs.

mantenie commented 9 years ago

:+1:

hlogmans commented 9 years ago

@pzuraq thanks for this fix, it's working for me, too.

selbyk commented 9 years ago

+1

wwwdata commented 9 years ago

can you please merge this? i want to end the pain

asaf commented 9 years ago

This problem got fixed today,

Sorry for the delay.