search

indexiatech / re-notif

Redux & React based Notifications center.
http://indexiatech.github.io/re-notif
BSD 3-Clause "New" or "Revised" License
148 stars 45 forks source link

npm and github versions differ a lot! #17

Closed venil7 closed 8 years ago

venil7 commented 8 years ago

whats in npm and what is here differ documentation does not match, etc....

jpollard-cs commented 8 years ago

@venil7 yep we're trying to get in contact with the owner to update the npm package cc: @kylecesmat

I'm going to try to reach out to @asaf via Twitter

jpollard-cs commented 8 years ago

okay I've reached out to @asaf on Google+ and Twitter (sorry @asaf if you get the same message three times - wasn't sure which Google+ profile and Twitter profiles were correct)

kylecesmat commented 8 years ago

@jpollard-cs @asaf @venil7 Yeah, we need to publish the latest to npm. If @asaf can make me a collaborator we could self-maintain this repo. Otherwise, we could rename this package on npm? (not ideal)

jpollard-cs commented 8 years ago

yeah let's give it a day or two then talk about alternatives - last time I used Twitter to get in touch with him it seemed to work

ErezSha commented 8 years ago

@kylecesmat You are already a collaborator on this repo. @asaf made you one after #9.

jpollard-cs commented 8 years ago

@ErezSha I think he means on npm...the builds/publishing are not automated

NameFILIP commented 8 years ago

yes, and the version in npm is 1.0.2, but in the source code - 1.0.1, which is weird

kylecesmat commented 8 years ago

Yeah - I'm going to make a tag on this repo today and if we don't hear from @asaf soon we'll make a new package on npm

NameFILIP commented 8 years ago

redux-notifications can be a good name for the new npm package

jpollard-cs commented 8 years ago

or just re-notify

kylecesmat commented 8 years ago

I personally prefer redux-notifications as it seems verbose. I'm weary to change the package name and break the version history. Any reason why we shouldn't?

jcheroske commented 8 years ago

Has a current version been published to npm? Has the name been changed?

jpollard-cs commented 8 years ago

@kylecesmat I have no strong feelings either way, but at this point I think we should publish a new npm package - no disrespect meant to @asaf, of course, but I think that would be a good solution until we hear from him

venil7 commented 8 years ago

yes please publish under new name

kylecesmat commented 8 years ago

Hey all! This issue can be closed, a new package has been created at redux-notifications here - https://www.npmjs.com/package/redux-notifications

I'd love to help continue to support this project, if @asaf no longer has time to maintain then transferring ownership could be a great option?

cc: @jpollard-cs @venil7 @jcheroske @NameFILIP @ErezSha