indexiatech / re-notif

Redux & React based Notifications center.
http://indexiatech.github.io/re-notif
BSD 3-Clause "New" or "Revised" License
148 stars 45 forks source link

Custom Component Errors/Warnings #50

Open prescottprue opened 7 years ago

prescottprue commented 7 years ago

When trying to use a custom component, one can trying passing a string or a whole component.

String

Does not seem to be a common pattern for passing a component

<Notifs CustomComponent={Snackbar} />

Problems

Full Component

Seems to the common method of accepting a component as a prop used in Libraries like material-ui like here. That way props can be passed and set within the component (like you are doing with key).

<Notifs CustomComponent={<Snackbar open message="some" />} />

Problems

kylecesmat commented 7 years ago

Thanks for this report! I'll look into reproducing this. I know the CustomComponent API could be beefed up, it was created for a small handful of usecases and the ones you've outlined seem likely.

If I have time I'll take a stab at a PR, but would love help from others!