search

indexiatech / re-notif

Redux & React based Notifications center.
http://indexiatech.github.io/re-notif
BSD 3-Clause "New" or "Revised" License
148 stars 45 forks source link

Support for React 15.x? #9

Closed hirako2000 closed 8 years ago

hirako2000 commented 8 years ago

Any plan to support for newer versions of React?

jpollard-cs commented 8 years ago

created a PR for this - there don't seem to be any issues running re-notif under react 15, but this is getting in the way of my shrinkwrapping :smiley:

kylecesmat commented 8 years ago

I'm working on a fork that removes ReactCSSTransitionGroups, as that's no longer bundled with 15

https://github.com/kylecesmat/re-notif

jpollard-cs commented 8 years ago

@kylecesmat awesome! Anything I can do to help expedite completion on that? Are you going to create a branch or publish as a separate npm package (unfortunately license is not standard, but seems like it can be published under a different name)? I'm not sure this if project is being actively maintained..

kylecesmat commented 8 years ago

@jpollard-cs I'm going to propose a PR, right now trying to work within the existing API for applying styles, should have that merged on my branch shortly and will propose a PR

kylecesmat commented 8 years ago

Proposed PR #11 would resolve this

hirako2000 commented 8 years ago

Considering PR(s) are stacking up.. We better publish a new lib: react-notif? Edit: I'm happy to merge the existing PR(s) later today and add you two as collabs so that we this nice lib gets a chance to be maintained

jpollard-cs commented 8 years ago

I'll try to see if I can find a way to get in touch with @asaf otherwise yes I'm for this

jpollard-cs commented 8 years ago

well I tweeted @ him lol - let's give it the day then start talking about alternatives

kylecesmat commented 8 years ago

I'd love to help maintain this package

jpollard-cs commented 8 years ago

yep I'd be happy to do so, as well - I did a diff on the standard BSD license and it appears this is pretty much the standard BSD license with some additional protection for contributors (which we will be) so I'm good with that - either way it appears it's still pretty much your standard non-copyleft free software license - I'd be happy to maintain an upstream fork and add you guys as contributors (unless someone else wants to own it)

jpollard-cs commented 8 years ago

He returns! Thanks for merging my PR @asaf :smile:

asaf commented 8 years ago

Hey guys, Thanks for participating and your contribution,

Lets make this component more awesome together :-)

@kylecesmat I made you a maintainer because you asked first :-) (One thing, please don't merge the lib folder within this project, I dislike lib code within the source repo)

(@jpollard-cs If there'll be more work I'll add you as well :) )

Asaf.

asaf commented 8 years ago

@jpollard-cs Sure!

jpollard-cs commented 8 years ago

@asaf please let us know when the npm package is updated

kylecesmat commented 8 years ago

@jpollard-cs will do! I'm going to work on polishing my PR and I'll submit for a review on the proposed changes. shouldnt take too long