search

indexiatech / redux-immutablejs

Redux Immutable facilities.
BSD 3-Clause "New" or "Revised" License
684 stars 36 forks source link

npm package cannot be used with Babel 6 #23

Closed natorojr closed 8 years ago

natorojr commented 8 years ago

I recently upgraded to Babel 6 and noticed the following issues w/ your npm package:

/project/node_modules/redux-immutablejs/lib/index.js: Unknown option: /project/node_modules/redux-immutablejs/.babelrc.stage

It's generally considered bad practice to publish .babelrc as part of your npm packages. Instead, you should be using the files attribute in your package.json (https://docs.npmjs.com/files/package.json#files).

Alternatively, you can upgrade your package to Babel 6.

natorojr commented 8 years ago

Note: My last comment wasn't valid...

Alternatively, you can upgrade your package to Babel 6.

... since doing so, without actually removing .babelrc from your package, could conceivably break people still using Babel 5 (which I think there are still many).

Therefore, the best option for everyone is to add the files prop to package.json (effectively excluding .babelrc from your npm distribution) and republishing the package.

I submitted PR #24