indexmap-rs / indexmap

A hash table with consistent order and fast iteration; access items by key or sequence index
https://docs.rs/indexmap/
Other
1.67k stars 150 forks source link

Use `serde_derive` via `derive` feature on `serde` #333

Closed waywardmonkeys closed 1 month ago

waywardmonkeys commented 1 month ago

This is the recommended way to do this in the serde docs.

waywardmonkeys commented 1 month ago

This is for the dev dependency only, so won't impact dependent crates of indexmap, so it won't run afoul of https://github.com/serde-rs/serde/issues/2584

cuviper commented 1 month ago

As you note by that issue, that recommendation is being reconsidered. I don't see any point in changing here -- what would we be fixing by doing so?

waywardmonkeys commented 1 month ago

I think best to close this!