search

indexzero / ps-tree

MIT License
149 stars 29 forks source link

Correct SPDX identifier #14

Closed sebdeckers closed 9 years ago

sebdeckers commented 9 years ago

This lets tools like npm or nlf report the license for this package.

See:

nelsonic commented 9 years ago

Thanks for pointing this out @cbas :+1: However for NPM to recognise this change we will need to publish a new version of the package which will require a bump in the version number in package.json (from 1.0.0 to 1.0.1). Would you mind increasing the version number in package.json so @indexzero can npm publish once this is merged. thanks.

sebdeckers commented 9 years ago

Your wish is my command :bow:

indexzero commented 9 years ago

Thanks for your contribution. I ended up just publishing this out using a pre-canned script I have for bumping things because the change was so minor. Also ended up dusting off some things setup because they had broken @nelsonic

indexzero commented 9 years ago

In particular there appears to be some order dependent side effects in the tests. This happened to fix it: https://github.com/indexzero/ps-tree/commit/2f5f4d22c92f55e0571edb762de09cb386a976e3

sebdeckers commented 9 years ago

Great! Thanks @indexzero :smile:

FYI you can bump versions with npm version patch (or minor or major). This checks if the repo is clean (no uncommitted changes) and also commits a tag which shows up nicely on GitHub Releases tab (and can be used as a special trigger by Travis and other CI services). https://docs.npmjs.com/cli/version