search

indexzero / ps-tree

MIT License
149 stars 29 forks source link

Win32 platform support #15

Closed huan closed 8 years ago

huan commented 8 years ago

@indexzero I had just finished a runable win32 version of ps-tree, include the following changes:

Code:

  1. use wmic.exe to simulate ps under win32 platform.
  2. map output header of wmic to ps
  3. strip the linux <defunct> from the output

    Test

  4. modify istanbul command line to support win32
  5. use npm module tree-kill to replace the kill to support win32
  6. use npm module cross-env to enable set environment variable in package.json

Hope this helps. :)

huan commented 8 years ago

See also #13

indexzero commented 8 years ago

This looks good. Will review and try to merge this weekend.

huan commented 8 years ago

@indexzero how about the process? I need the new npm package to enable my code to support win32. :)

indexzero commented 8 years ago

@zixia merged this with some minor changes. The biggest thing in your PR that I need help from you with is getting Appveyor working. TravisCI does not support Windows so adding windows in .travis.yml did not add WIndows CI support.

Could you help me setup Windows CI on this project? Thanks again for your contribution!

huan commented 8 years ago

cool. I'll pay attention on win32 ci... it seems there's no existing ci service to provide win32, it's funny.

indexzero commented 8 years ago

Appveyor CI does work with Windows. https://www.appveyor.com/

huan commented 8 years ago

great. I'm working on it now, it's pretty cool to test our code on win32...

huan commented 8 years ago

I just setup a appveyor.yml and it's live here(with a failure) https://ci.appveyor.com/project/zixia/ps-tree

then I saw you already have a .appveyor.yml file.

I thought your .appveyor.yml will not work, because doc says the filename without the pre-dot?