search

indexzero / ps-tree

MIT License
149 stars 29 forks source link

Global leak in published NPM version 0.0.2 #3

Closed brianedgerton closed 11 years ago

brianedgerton commented 11 years ago

I'm using forever-monitor which has a dependency on 0.0.x and my test suite is throwing global leak errors due to the declaration of child on line 15 of index.js. Please see:

https://github.com/nodejitsu/forever-monitor/issues/10

Will this be fixed or will the latest version of ps-tree be published to NPM any time soon?

Thanks, Brian

jbrumwell commented 11 years ago

@indexzero leak should be fixed, just need you to publish to npm

brianedgerton commented 11 years ago

I was just looking at the pull request and I'm wondering what adding a "var child" to the childrenOfPid method is going to solve since there isn't a child variable being used anywhere else. The version of index.js in master is quite different than the latest version on NPM.

Thoughts?

jbrumwell commented 11 years ago

@brianedgerton thanks, you are correct I had installed from npm ran added the var then ran it through my tests that were complaining about it, they didn't error out so cloned and added the var. I had assumed npm == master, which isn't the case. Should just have to publish it.

brianedgerton commented 11 years ago

With this version being so different from the NPM version (and with no trace of the NPM version in the tree), I'm wondering if it's still going to be compatible with anything that depends on it. A coworker and I are planning to refactor a bit and add some tests.

@indexzero Do you have any thoughts on why master and NPM are so different?

indexzero commented 11 years ago

@brianedgerton It's simple: @dominictarr didn't care about the library.

indexzero commented 11 years ago

Thanks guys. Published to npm as ps-tree@0.0.3