indeyets / appserver-in-php

Generic HTTP applications approach for PHP5.3+ (inspired by Rack and WSGI)
BSD 3-Clause "New" or "Revised" License
291 stars 23 forks source link

Consider opening the API #27

Open xrstf opened 12 years ago

xrstf commented 12 years ago

I'm trying to work around issue #23. For this, I tried to simply use a custom storage implementation that has my patch (LOCK_SH) in it.

Unfortunately, nearly everything inside the Session middleware is private, so for making a simple patch to lock() I have to copy nearly everything. Not just because most of the stuff is private, but because most methods directly access the properties (instead of using a getter).

This makes it extremely hard and ugly to subclass AiP. I would suggest using protected more often and/or introducing some getters where properties must be private.