search

indiana-university / rivet-datepicker

A datepicker widget for Rivet that uses Pikaday
https://indiana-university.github.io/rivet-datepicker/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Daylight/Standard shift breaks adjustDate calculation #5

Open dwaicuka opened 4 years ago

dwaicuka commented 4 years ago

The adjustDate function here: https://github.com/indiana-university/rivet-datepicker/blob/a31d73f647c21b2f26b489e84bfc133ae4968e86/dist/js/rivet-datepicker.js#L791 does not account for the change between daylight and standard time. I have found this bug is also present in Pikaday's datepicker code.

Here in Indiana, where we do observe daylight savings, if you select November 3, 2019 in a datepicker, and use the right arrow to go to the next day, it does not move. If you select March 9, 2020, and hit the left arrow, it jumps to March 7.

The function see the first day as "Mon Mar 09 2020 00:00:00 GMT-0400 (Eastern Daylight Time)" and the newDay as "Sat Mar 07 2020 23:00:00 GMT-0500 (Eastern Standard Time)". Or for November 3rd, it sees the first day as "Sun Nov 03 2019 00:00:00 GMT-0400 (Eastern Daylight Time)" and the newDay as "Sun Nov 03 2019 23:00:00 GMT-0500 (Eastern Standard Time)".

Using the up and down arrows to move a week at a time shows the same issue. If you're on "Fri Nov 01 2019 00:00:00 GMT-0400 (Eastern Daylight Time)" and hit the down arrow it sees the newDay as "Thu Nov 07 2019 23:00:00 GMT-0500 (Eastern Standard Time)". And the same for the up arrow for the week following March 9, 2020. On "Thu Mar 12 2020 00:00:00 GMT-0400 (Eastern Daylight Time)" hit the up arrow key and it moves to "Wed Mar 04 2020 23:00:00 GMT-0500 (Eastern Standard Time)."

dwaicuka commented 4 years ago

FYI: I was directed to an open Pikaday pull request that fixes this issue: https://github.com/Pikaday/Pikaday/pull/716