search

indiana-university / rivet-icons

Icons for Indiana University's Rivet Design System
https://rivet.iu.edu/icons-stickers/
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Upgrade icons #103

Closed basham closed 1 year ago

basham commented 1 year ago

Notes:

  1. All icons (210 total) are now built in Figma, instead of Illustrator.
  2. New icons caution and caution-solid resolves #3.
  3. New icons shopping-cart and shopping-cart-solid resolves #41.
  4. New icons link, thumbs-down, thumbs-down-solid, thumbs-up, and thumbs-up solid partially resolves #55. Should confirm if a Bold ("B"), Heading ("H"), Italics ("I"), and Border icons are still needed.
  5. Confirm if updates to check resolves #62.
  6. New icons grid-horizontal and grid-vertical resolves #77.
  7. New icons inbox, inbox-solid, inbox-complete, and inbox-complete-solid resolves #84.
  8. New icons globe and globe-solid resolves #96.
  9. If we keep any breaking changes, this should be a 2.0.0 release (and the @1 references in the readme should be updated to @2). If not, this will be release 1.1.0.

Current breaking changes (confirm if we want to do this):

  1. audio-on is renamed to audio.
  2. question-mark is renamed to question.
  3. rss is renamed to rss-feed.
  4. transfer-alternate is renamed to transfer-alt.
  5. users is renamed to user-group.
  6. users-group-solid (3 people) is removed.
levimcg commented 1 year ago

@basham This look excellent! Love all the new icons 😄. Re: breaking changes. I'm fine with this being a major release and moving to 2.0.0. We can make that clear when we send out our communications to the larger community.

I think a question we might need to figure out when we meet next is how to handle the current docs (Eleventy site). We've got the new icons docs section on the Rivet site in test are just about ready to launch it. The last step is updating to the new (2.0.0) release and then launching the site. I can share those docs when we get together in the next couple of weeks so we can sort out updating/adding links to the new docs on the Rivet site here in this repo.

basham commented 1 year ago

I'm fine with breaking changes as well. I'd like to not maintain two documentation sites, but we still need a way to test the icons after any changes. If that can't easily be done with the new documentation site, then perhaps this Eleventy site should remain. However, we could remove the gh-pages branch and not make it a public site. It could instead be used for development and testing the icon set itself.

basham commented 1 year ago

@levimcg I've made name changes, after consulting with Jenn. I've upgraded deps. It is ready for review.

All breaking changes in this PR

Renamed icons:

Removed icons: