search

indiana-university / rivet-icons

Icons for Indiana University's Rivet Design System
https://rivet.iu.edu/icons-stickers/
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

New Icon Requests: 'star' and 'slash' #29

Closed christiemh54 closed 5 years ago

christiemh54 commented 5 years ago

We use the star and slash icons to represent positive and negative service indicators in AdRx. These are carry over icons that are widely recognized by AdRx and SIS users.

image

basham commented 5 years ago

Following conventions I'm noticing in the current icon set, I think star should be an outlined version of the star. If wanting a solid version, that would probably be called star-solid.

Given stars could be used for favoriting or rating things, I feel like both versions could be useful, even if AdRx just needs one of them.

The slash icon should probably be called ban.

christiemh54 commented 5 years ago

@levimcg @basham (I couldn't find Cody to tag) Nat would like to get this released with our student summary page for AdRx in the next sprint, so if any of you have time and could get these icons completed by May 13, that would allow us to do that. Thanks!

basham commented 5 years ago

@levimcg I may have some time this Friday to work on this issue. However, that may mean that this work will need to be merged before your #33 PR, in order for the icons to be ready for @christiemh54's requested deadline. I assume that should be okay with you?

levimcg commented 5 years ago

Yep, totally fine, do what you need to do, and I'll pull in any changes if I can't get my PR finished before. 👍

basham commented 5 years ago

@christiemh54 The ban, star, and star-solid icons are now available in the master branch and viewable in the icon set demo.

basham commented 5 years ago

@levimcg Please close this issue.

christiemh54 commented 5 years ago

@basham looks great, thank you for getting it done this week!