search

indiana-university / rivet-icons

Icons for Indiana University's Rivet Design System
https://rivet.iu.edu/icons-stickers/
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

Add star and star-solid icons #38

Closed basham closed 5 years ago

basham commented 5 years ago

I used Illustrator's star tool to generate the star. I played around with a number of settings, primarily adjusting the inner radius. The third one of these 4 samples (inner radiuses: 2.75, 3.0, 3.5, 4.0) seemed to be the best configuration for both an outline and solid version of the star.

Star samples with different inner radiuses

I created it with Radius 1: 7px (outer) and Radius 2: 3.5px (inner).

Star configuration dialog in Illustrator

I kept the middle of the star in the middle of the art board, instead of centering the bounding box of the star to the art board. This should ensure the star feels more vertically balanced. But if we need to revisit that, we can.

The center of the star is not the center of its bounding box

These are my proposed star and star-solid icons.

star icon star solid icon

basham commented 5 years ago

Please review, @levimcg. This PR should resolve #29.