search

indiana-university / rivet-icons

Icons for Indiana University's Rivet Design System
https://rivet.iu.edu/icons-stickers/
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Upgrade deps #98

Closed basham closed 2 years ago

basham commented 2 years ago

I'd like to release a patch update (v1.0.3) that upgrades all the dependencies of this project. Notes:

  1. I've noticed a similar security warning to this one in other projects. That is a result of svg-sprite. I've updated it to the new v2.0.0 released a few weeks ago. I don't know if it will resolve it, but it is our best chance to do so.
  2. The changes in svg-sprite means that it minified the symbols in rivet-icons.html, rivet-icons.js, and rivet-icons.svg slightly differently. However, I'm not noticing any visual regressions in the docs site that I served locally.
  3. The icons continue to work and look identically in the latest Chrome, Firefox, and Safari.
  4. I upgraded gh-pages. It claims that there are no breaking changes in this new 4.0.0 release. I have not tested this, but I'm sure it will be fine.
  5. There were some changes I needed to make in build.js to accommodate depreciation warnings in Node 16.
  6. All dependencies in package-lock.json are resolved through the public npm registry, instead of the IU Nexus one. That makes it friendlier, as those who try to run this repo will no longer need any special authentication.
basham commented 2 years ago

Excellent. Could you take care of publishing this update? Want me to merge it, or will you do that?

levimcg commented 2 years ago

I can go ahead and merge it and publish the update. I've got to run out for the day here in about five, but I can do it first thing Monday if that's cool?

basham commented 2 years ago

Yep, good for me. No rush. Thanks!