search

indiana-university / rivet-react

Rivet React Component Documentation and Style Guide:
https://indiana-university.github.io/rivet-react/
Other
5 stars 5 forks source link

fix: don't use role in badge/button prop #449

Closed burnumd closed 1 month ago

burnumd commented 1 month ago

Role is a reserved ARIA attribute. We already refer to the Button property as modifier though the PropTypes don't reflect that.

Closes #448

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.35%. Comparing base (124693b) to head (aa4954e). Report is 1 commits behind head on beta.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #449 +/- ## ======================================= Coverage 99.35% 99.35% ======================================= Files 88 88 Lines 1234 1234 Branches 179 179 ======================================= Hits 1226 1226 Misses 2 2 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iu-deployer commented 1 month ago

:tada: This PR is included in version 2.0.0-beta.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: