search

indiana-university / rivet-react

Rivet React Component Documentation and Style Guide:
https://indiana-university.github.io/rivet-react/
Other
5 stars 5 forks source link

Issues using Header.Avatar #462

Open burnumd opened 2 weeks ago

burnumd commented 2 weeks ago

Header.Avatar has a few issues:

  1. When used in a header, it should be documented that it goes inside BaseHeaderNavigation.
  2. The avatar component itself is in a div, but when included in header navigation, it is erroneously put inside the ul tag

It is likely that the Avatar information should be included as props to BaseHeader instead of being provided as a component since the positioning of it is highly specific. Either that, or detect when an Header.Avatar component is included as a child of BaseHeaderNavigation and place it outside the generated ul tag.

iu-deployer commented 2 weeks ago

:tada: This issue has been resolved in version 2.0.0-beta.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: