search

indiana-university / rivet-source

Indiana University’s design system for web application development
https://rivet.iu.edu
BSD 3-Clause "New" or "Revised" License
54 stars 5 forks source link

Switch: Adjust height, add medium variant #730

Closed basham closed 7 months ago

basham commented 8 months ago

Notes:

  1. Adjusted the default height from 44px to 40px to match the height of buttons.
  2. Added a medium variant at 32px in height.
  3. Cleaned up styles to minimize overrides for variants.
  4. Replaced "On" icon transition from translate to left. This allows it to animate flush right regardless of the width of the button container. With left, percentage values are relative to its container. With translate, percentage values are relative to itself.
  5. This has been visually tested in Chrome, Firefox, and Safari.
basham commented 7 months ago

Reviewed the PR with @levimcg today. Decisions:

basham commented 7 months ago

@levimcg: Ready for review.