Closed basham closed 7 months ago
I've made this is PR a draft until the questions are addressed. We may need a meeting to discuss the direction.
@basham Cool! Thanks for getting this open. Yes, I'd be happen to schedule something face-to-face to chat through some of this before we continue.
Reviewed the PR with @levimcg today. Decisions:
xs
. This will provide default spacing for icons and the text content, so we don't have to use the margin utility.32px
wide. This provides a more comfortable look, even though it means they are not square (like the large and medium buttons).@levimcg: Ready for review.
Notes:
2px
on each side, so that normal-sized icon buttons are 40 square pixels.rvt-button--medium
variant, with32px
height.Questions:
rvt-m-left-xs
? Or does that presume too much about the contents of buttons and how they should be used?2px
horizontal padding for small buttons seems insufficient, in order to ensure that small icon buttons remain 24 square pixels. Does this indicate that perhaps the padding should be dynamic, according to if the visible content is an icon only verses icon with label verses just label?