search

indianpoptart / RadioControl

An app that auto toggles wifi and cell radio for maximum battery life
https://nikhilp.org/radiocontrol
GNU General Public License v3.0
16 stars 7 forks source link

VT PUP alerts #63

Closed IzzySoft closed 6 years ago

IzzySoft commented 6 years ago

Since v5.0 (when you introduced all those Analytics and Firebase) the .apk raises some alerts at VirusTotal: v5.0 and v5.0.1. As the library count increased by almost factor 2 with v5, it could of course also be some other 3rd party element responsible. Could you please have a look?

indianpoptart commented 6 years ago

Sure thing! I'm not quite sure why it would be doing that, but I'll do some research and let you know

indianpoptart commented 6 years ago

I can assure you the app is safe. Not sure how much my word will go since I am some random person, but yeah, I'd never put any viruses in my app, I'll check in Android Studio, as well as a scan of my repository

IzzySoft commented 6 years ago

I didn't blame you or your app! In most cases it's either one of the libraries having an issue – or an update to studio components is fixing things. I just wanted to let you know before it pops up in a different way :wink:

indianpoptart commented 6 years ago

Just letting you know :) Don't want people to think I'm putting viruses. I greatly appreciate you bringing it to my attention. Hopefully, it's an easy fix! Might be that I have to update the ads library or something 😄

IzzySoft commented 6 years ago

Or simply leave out all the ad, analytics and Firebase stuff for the non-playstore version. Might even make it ligit for F-Droid then :wink:

indianpoptart commented 6 years ago

True, Although, I make sure all 3rd party features can be turned off. Ads are always on, unless disabled. Analytics, firebase, and fabric.io are all opt-in. Def going to work on making a non-playstore version. Do you know if there's a way in Android Studio to generate an apk without those features enabled? Or would I have to manually remove libraries and code. Thanks!

Also, I tried F-Droid a few months ago, was too complex to setup, but I love F-droid in general!

IzzySoft commented 6 years ago

What you're looking for are gradle flavors. I'm no dev, so I cannot give details on that – but that's what F-Droid often uses in such cases.

As you're already looking toward F-Droid: until you get the code/gradle-flavor ready, your app can already be found here :wink:

indianpoptart commented 6 years ago

Sounds good, I'll try out gradle flavors. Thanks for putting my app in your repo! Looks great!

indianpoptart commented 6 years ago

Ayy, I fixed it

IzzySoft commented 6 years ago

Confirmed! No alert anymore for the latest release. May I ask who was the culprit? Arguing by the library list I'd say one of those nasty ad modules you thankfully removed?

indianpoptart commented 6 years ago

I think it was the ads, should be all gone now!, Except for some calls to disabling ads in Settings

Also updated all android support libraries to SDK 27

IzzySoft commented 6 years ago

Superb! So I guess we can close this? Unless you want to keep it open as reminder for some "after-work" that is?

indianpoptart commented 6 years ago

Yeah, all good. Thanks for all your help!

IzzySoft commented 6 years ago

Glad to! Thanks for the nice and fast fix!