Pull Request - Githubissues

indic-transliteration / sanscript.js

Transliteration package for Indian scripts

MIT License

98 stars 39 forks source link

Pull Request #5

Closed Shreeshrii closed 7 years ago

Shreeshrii commented 9 years ago

Changes to Sanscript

akprasad commented 9 years ago

Hey, thanks for making these changes! In addition to my comments above, please address the following:

Please make your commit messages more descriptive; "gujarati characters fix" doesn't communicate much.
Please use the commit style described here.
Please add tests for your new code.

I hope this isn't too much to ask. I really appreciate that you've taken the time to do this, and I want to get this checked in soon. :-)

Shreeshrii commented 9 years ago

Hi Arun, Thanks for sanscript, it is an elegant piece of code!

I am new to git and had accidently created this pull request from Naresh's repo, when I should have forked his repo and commited my changes to it and created pull request there.

Naresh is still making changes to the script for use on sanskritdocuments.org and we'd welcome your input for making changes for malayalam also.

Thanks, Shree

Shreeshrii commented 7 years ago

Please merge relevant changes from the current version of shreeshrii/sanscript.js - which is being used at sanskritdocuments.org. Thanks!

I am closing this PR.