search

indic-transliteration / sanscript.js

Transliteration package for Indian scripts
MIT License
98 stars 39 forks source link

Can the preinstall script be removed ? #64

Closed lorefnon closed 1 year ago

lorefnon commented 1 year ago

Hello, thanks for creating this repo.

Curious if this preinstall script is still needed ? From the discussion here it seems that you were using submodules before but migrated away from that. The current list of submodules is just empty.

Unless you plan on adding any more submodules in near future, it would be good to remove this because this causes npm install or npm ci to fail in scenarios where the consumer project is not a git repo. We encountered this when running npm ci inside a docker container - we don't clone the whole of our repo into the image.

vvasuki commented 1 year ago

Please remove, test and send pull request.