Direct access link for epayment is wrong

indico / indico

Indico - A feature-rich event management system, made @ CERN, the place where the Web was born.

https://getindico.io

MIT License

1.79k stars 432 forks source link

Direct access link for epayment is wrong #1805

Closed nop33 closed 9 years ago

nop33 commented 9 years ago

In the management area ()/event/XXXXXX/manage/registration/users/X/, the link to epayment of the registrant is incorrect:

It should be replaced by the link to the registration page.

ThiefMaster commented 9 years ago

I think we should only show this link if the user has no indico account. Otherwise it's kind of pointless, and if we included the authkey in that case we'd point to a page that, if logged in to a different account, would be a bit broken since any links on that page would not include id and key

nop33 commented 9 years ago

So how should I proceed with this?

if the registrant has an Indico account, then the link would be /event/X/registration/, which is pointless as @ThiefMaster said.
if the registrant has no acc, then the link would contain the authkey and registrant_id parameters, but still, if the manager clicks on that link, the page would be a bit broken, as mentioned above.

Should I only add the link in case of a registrant without an acc?

ThiefMaster commented 9 years ago

One option would be to show it only if the guy doesn't have an account and add a message indicating that it should not be used while logged in to an indico account.

nop33 commented 9 years ago

OK, I added the correct link only when the guy has no account:

pferreir commented 9 years ago

"While logged in with an Indico account"