indico / indico

Indico - A feature-rich event management system, made @ CERN, the place where the Web was born.
https://getindico.io
MIT License
1.78k stars 431 forks source link

A timezone which leads to "day-wrapping" seems to confuse the timetable rendering code #4901

Open pferreir opened 3 years ago

pferreir commented 3 years ago

Describe the bug

This happened in an event happening in Europe/Zurich as seen in Asia/Seoul.

e.g.

image

becomes:

image

Which seems OK, only that the second day is incorrectly rendered:

image

(that last green block should have been at midnight)

In detailed view things get even worse:

image

becomes:

image(these should be on Tuesday, not here) [plus, further down the page...]

image

(only this last part is correct)

To Reproduce Steps to reproduce the behavior:

  1. Open https://indico.cern.ch/event/1016060/timetable/#20210510;
  2. Set your timezone to Asia/Seoul;
  3. You will notice the timetable is a bit of a mess.

Expected behavior

The time should be offset of 7h, with the "first day" of the event starting at 21:00 and finishing already on Tuesday (at 1:10 local time). The last two talks of the day should be shown on the day after.

Additional context Reported at CERN, through INC2786935

pferreir commented 3 years ago

Possible duplicate of #3073?

pferreir commented 3 years ago

Ok, I gave it 1h of my time and the conclusion is that the cost of fixing the logic in the rendering code would be too high at this point. I'd prefer that we focus our resources on coming up with a new version of the timetable in 2022.

pferreir commented 3 years ago

Closing in favour of #3073