add Total counters and fix stack traces when not connected

indiefan / king_smith

Home Assistant Integration for King Smith treadmills (e.g. WalkingPad)

MIT License

17 stars 8 forks source link

add Total counters and fix stack traces when not connected #20

Closed Links2004 closed 5 months ago

Links2004 commented 7 months ago

add Total counter that still work after HA restart fix stack traces when not connected

work based on status changes of @mia-recki

Tested with my A1 Pro

Brazier85 commented 6 months ago

Would be nice to see this added to the main branch!

KuzmaTolyanuch commented 5 months ago

Hi @indiefan, Thank you for initial integration, please consider merging this PR, since it fixes BLE reconnection issues as well as adds some useful sensors. @Links2004, thank you for new functionality and stability update, Tested on my KingSmith K12, works flawlessly with ESP32 Bluetooth proxy I had to add one more local_name "KingSmith" into manifest.json for autodiscovery.

indiefan commented 5 months ago

Thanks for the contribution! Sorry for the delay in getting to this.

indiefan commented 5 months ago

Looks like there's at least one formatting nit (missing docstring. see: https://github.com/indiefan/king_smith/actions/runs/8364320516/job/22899364856). If you take a look and resolve then I will push an updated release with your changes.

Thanks!